[Mesa-dev] [V4 PATCH 0/7] mesa: Naming MESA_FORMATs to a specification

[Marek Olšák]

Tested with piglit and pushed. Nice work!

Marek

On Mon, Jan 27, 2014 at 1:10 AM, Mark Mueller <markkmueller at gmail.com> wrote:
> Thanks Marek,
> I sent out a new set of patches, otherwise there is a branch called
> NewStartAMF at fdo:~mmueller/mesa with everything in.
>
> Mark
>
>
> On Sun, Jan 26, 2014 at 3:03 PM, Marek Olšák <maraeo at gmail.com> wrote:
>>
>> Mark,
>>
>> I will do it if you send me a git link to your branch which merges
>> cleanly and compiles successfully.
>>
>> Marek
>>
>> On Sun, Jan 26, 2014 at 10:27 PM, Brian Paul <brian.e.paul at gmail.com>
>> wrote:
>> > On Sun, Jan 26, 2014 at 11:45 AM, Mark Mueller <markkmueller at gmail.com>
>> > wrote:
>> >>
>> >>
>> >>
>> >>
>> >> On Fri, Jan 24, 2014 at 2:50 AM, Marek Olšák <maraeo at gmail.com> wrote:
>> >>>
>> >>> On Thu, Jan 23, 2014 at 8:36 PM, Kenneth Graunke
>> >>> <kenneth at whitecape.org>
>> >>> wrote:
>> >>> > On 01/23/2014 11:19 AM, Mark Mueller wrote:
>> >>> >> That works for sRGB, but what about other color spaces that may be
>> >>> >> added in
>> >>> >> the future? I'm fine with leaving that to another day and with
>> >>> >> using
>> >>> >> the
>> >>> >> _SRGB decoration, as you say.
>> >>> >
>> >>> > Oy.  Let's not worry about things that hypothetically could be
>> >>> > someday.
>> >>> >  We need to do what makes sense today.
>> >>>
>> >>> Yeah, let's commit this. We can discuss the other things later,
>> >>> including if SRGB should be a type or a modifier. The series is
>> >>> already pretty good.
>> >>>
>> >>> Marek
>> >>
>> >>
>> >>  I'm not sure if further acknowledgement is needed to push the series,
>> >> but, either way, I'm not authorized to push these.
>> >
>> >
>> > The series looks good to me too, but I'd also like to see the _UNORM8 ->
>> > _SRGB suffix change in a follow-up patch.
>> >
>> > I tried applying the patch series to my local tree but it doesn't apply
>> > cleanly.  My recent "mesa: add missing ETC2_SRGB cases in formats.c"
>> > change,
>> > and possibly others are at fault.  Sorry.
>> >
>> > If you can rebase the series on top of master I can apply them, unless
>> > Marek
>> > beats me to it (I'm in the midst of traveling today).
>> >
>> > -Brian
>> >
>
>