[Mesa-dev] [PATCH 1/2] glsl: s/_NDEBUG/NDEBUG/

Ian Romanick idr at freedesktop.org
Tue Jan 28 14:19:46 PST 2014


On 01/23/2014 11:03 AM, Emil Velikov wrote:
> The former symbol is never defined within mesa. Based
> it seems that the original intent was to use NDEBUG.

That seems right to me.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

It looks like this code was originally written by Paul, so he may have
some comment.

> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>  src/glsl/ir.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/glsl/ir.h b/src/glsl/ir.h
> index 19e8383..e266328 100644
> --- a/src/glsl/ir.h
> +++ b/src/glsl/ir.h
> @@ -471,7 +471,7 @@ public:
>     void reinit_interface_type(const struct glsl_type *type)
>     {
>        if (this->max_ifc_array_access != NULL) {
> -#ifndef _NDEBUG
> +#ifndef NDEBUG
>           /* Redeclaring gl_PerVertex is only allowed if none of the built-ins
>            * it defines have been accessed yet; so it's safe to throw away the
>            * old max_ifc_array_access pointer, since all of its values are
> 



More information about the mesa-dev mailing list