[Mesa-dev] [Bug 74166] New: piglit CorrectVersion1.V110 regression regression

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=74166

          Priority: medium
            Bug ID: 74166
          Keywords: regression
                CC: cworth at cworth.org, idr at freedesktop.org,
                    jljusten at gmail.com, mattst88 at gmail.com
          Assignee: mesa-dev at lists.freedesktop.org
           Summary: piglit CorrectVersion1.V110 regression regression
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: vlee at freedesktop.org
          Hardware: x86-64 (AMD64)
            Status: NEW
           Version: git
         Component: Mesa core
           Product: Mesa

$ ./bin/glslparsertest tests/glslparsertest/shaders/CorrectVersion1.V110.frag
fail 1.10
Successfully compiled fragment shader
tests/glslparsertest/shaders/CorrectVersion1.V110.frag: 
Shader source:
// [config]
// expect_result: fail
// glsl_version: 1.10
//
// # NOTE: Config section was auto-generated from file
// # NOTE: 'glslparser.tests' at git revision
// # NOTE: 6cc17ae70b70d150aa1751f8e28db7b2a9bd50f0
// [end config]

/* Only one version statement is allowed; two should raise an error. */
#version 110
#version 110

void main()
{
   gl_FragColor = vec4(1);    
}

PIGLIT: {'result': 'fail' }



3e0e9e3bf9e597eb74b06381b3418c958be4d452 is the first bad commit
commit 3e0e9e3bf9e597eb74b06381b3418c958be4d452
Author: Matt Turner <mattst88 at gmail.com>
Date:   Sat Jan 25 11:57:02 2014 -0800

    glcpp: Check version_resolved in the proper place.

    The check was in the wrong place, such that if a shader incorrectly put
    a preprocessor token before the #version declaration, the version would
    be resolved twice, leading to a segmentation fault when attempting to
    redefine the __VERSION__ macro.

     #extension GL_ARB_sample_shading: require
     #version 130
     void main() {}

    Also, rename glcpp_parser_resolve_version to
                 glcpp_parser_resolve_implicit_version to avoid confusion.

    Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
    Reviewed-by: Carl Worth <cworth at cworth.org>
    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

:040000 040000 76acfdd0bf7846e51a3fa988fdd58f74a57f8dce
1265d3bc1b129beae3f07a28ab4e2f0b1261feda M    src
bisect run success

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140129/367b7951/attachment-0001.html>