[Mesa-dev] [PATCH] loader: Make drmGetVersion logic conditional on non-pci devices

[Kristian Høgsberg]

On Thu, Jan 30, 2014 at 12:20 AM, Stéphane Marchesin
<stephane.marchesin at gmail.com> wrote:
>
>
>
> On Thu, Jan 30, 2014 at 12:07 AM, Eric Anholt <eric at anholt.net> wrote:
>>
>> Stéphane Marchesin <marcheu at chromium.org> writes:
>>
>> > On systems without libudev, the loader_get_pci_id_for_fd() call will
>> > return 0, which will trigger the drmGetVersion logic. Sadly, this
>> > logic assumes that the kernel driver name matches the dri driver name,
>> > which is not the case on recent intel GPUs (for example i965 dri
>> > driver and i915 kernel module).
>> >
>> > This patch changes this logic by making it conditional on a list of
>> > known non-pci drivers (freedreno and tegra). This fixes dri on machines
>> > without libudev.
>>
>> So, why are Linux people building without libudev?  Is it just that we
>> forgot to make libudev-devel required in configure.ac?
>
>
> I talked with krh on irc, he seemed opposed to it. But yes, that would be
> fine by me. That said, it doesn't answer the question of other OSes. What
> should we do there?

I think I made a snarky remark, but I'm not opposed.  I introduced the
libudev dependeny in the first place and I'd be happy to just make
udev a hard requirement. On the other hand, we could keep glx+dri2
working without udev as it has in the past, and only require it for
new window systems (egl, glx+dri3) that have always required it.  I'm
fine either way.

Kristian

> Stéphane
>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>