[Mesa-dev] [PATCH] Bad free in _mesa_delete_buffer_object

[Brian Paul]

On 01/31/2014 04:08 AM, Colin Harrison wrote:
> Hi,
>
> I can get a crash without this change (now _mesa_align_malloc is being used
> for buffer object data)
>
> --- ./src/mesa/main/save_bufferobj.c    2014-01-29 17:23:22.387706584 +0000
> +++ ./src/mesa/main/bufferobj.c 2014-01-31 11:01:26.164078585 +0000
> @@ -407,7 +407,7 @@ _mesa_delete_buffer_object(struct gl_con
>   {
>      (void) ctx;
>
> -   free(bufObj->Data);
> +   _mesa_align_free(bufObj->Data);
>
>      /* assign strange values here to help w/ debugging */
>      bufObj->RefCount = -1000;
>
> Thanks,
> Colin Harrison

Yeah, that's the right fix.  I'll check that in shortly.

I was able to trigger the problem with the Xlib driver when 
HAVE_POSIX_MEMALIGN isn't defined.

-Brian