[Mesa-dev] [PATCH] glsl: Expand non-expr & non-swizzle scalar rvalues in vectorizing.

[Carl Worth]

Matt Turner <mattst88 at gmail.com> writes:
> ---
>  src/glsl/opt_vectorize.cpp | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)

Hi Matt,

I'm missing the rest of your commit message besides the one-line
summary.

I think the discipline of always typing _something_ there is valuable. I
like to call the one-line summary the "what" of the commit message, and
the following paragraph the "why".

And it's the "why" that's particularly important during review.

In this particular case, I'm not very familiar with the code being
modified, (I'm trying to do more active review of mesa patches as a way
of getting more familiar with the code). A bit more of the why would
help me in my review here. What's the value of the change here?
Correctness or optimization? Do you have example code sequences that
would not be operated-on by the previous code, but that will be by the
new code?

You don't need to answer all of those questions in the commit
message. But I bet if you wrote a sentence or two, I'd have pretty good
guidance for at least some of those answers.

Thanks for helping out a Mesa newbie here,

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140131/ac328d21/attachment-0001.pgp>