[Mesa-dev] [PATCH] i965: Ignore 'centroid' interpolation qualifier in case of persample shading

[Carl Worth]

Anuj Phogat <anuj.phogat at gmail.com> writes:
> I missed this change in commit f5cfb4a. It fixes the incorrect
> rendering caused in Dolphin Emulator.

It's too late for my review to change anything, but since I was recently
adding this commit (and the previous one being touched-up here) to my
ignore list, I noticed something that I think worth mentioning.

Your original commit had a good commit message:

i965: Ignore 'centroid' interpolation qualifier in case of persample shading

But then after you noticed a mistake, the subsequent commit has the same
commit message. This confused me at first when I saw two different
commits in the history with the same message.

In this particular case, the commit message does still seem to be
descriptive of the change. So I can't really say that it's an
inappropriate commit message.

But it still might have helped to at least have the message be distinct.

Maybe something like:

i965: Another case to ignore 'centroid' qualifier with persample shading

But like I said, it's too late to change anything, and it's not really a
big deal.

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140131/90a68b87/attachment-0001.pgp>