[Mesa-dev] [PATCH 3/3] i965: Use brw_bo_map[_gtt]() in intel_miptree_map_raw().

Carl Worth cworth at cworth.org
Fri Jan 31 13:45:55 PST 2014


Kenneth Graunke <kenneth at whitecape.org> writes:
> This code is strange anyway; the typical paradigm is to check whether
> the batch references the buffer, flush it if so, and then check whether
> it's busy.

I really like the series. So, thanks!

As far as your comment here, am I understanding that the (minor,
not-directly-intended) behavioral change you make in the code moves
things closer to the standard paradigm?

But is there still more that would move this even closer? Would that be
worth doing here (in a separate commit) now that you've seen it and
noticed?

I'll leave that for you to decide. In the meantime, for the series:

Reviewed-by: Carl Worth <cworth at cworth.org>

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140131/7cb9798d/attachment-0001.pgp>


More information about the mesa-dev mailing list