[Mesa-dev] [PATCH v2 0/4] i965: Add runtime checks for line antialiasing in Gen < 6.

Iago Toral Quiroga itoral at igalia.com
Thu Jun 5 06:03:04 PDT 2014

Updated series based on review comments.

Most important change in the series is related to the use of JMPI instead of
IF/THEN/ELSE: in order to use JMPI I moved this part of the code to the
generator (previous patch did the conditional in the visitor) because we need
to count the number of instructions we need to jump over and some of these
instructions will be in the generator anyway, so producing the JMPI instruction
in the visitor looks like a bad idea in this case.

Patch 1 is irrelevant for this series. It is a fix for a problem I ran into
when developing the first version based on IF/THEN/ELSE.

Patch 2: Provides the generator with the information it requires to implement
handle the runtime conditional in Gen < 6.

Patch 3: Makes brw_land_fwj_jump generally available again.

Patch 4: Implements JMPI based runtime checks for line antialiasing in Gen < 6.

Tested in Ironlake.

Iago Toral Quiroga (4):
  i965: Always set a valid block end pointer
  i965/fs: Let the gen < 8 generator know about runtime_check_aads_emit
  Revert "i965: Move brw_land_fwd_jump() to compilation unit of its
  i965/fs: Add Gen < 6 runtime checks for line antialiasing.

 src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp |  2 +-
 src/mesa/drivers/dri/i965/brw_cfg.cpp           |  5 ++
 src/mesa/drivers/dri/i965/brw_eu.h              |  4 ++
 src/mesa/drivers/dri/i965/brw_eu_emit.c         | 17 +++++
 src/mesa/drivers/dri/i965/brw_fs.cpp            |  2 +-
 src/mesa/drivers/dri/i965/brw_fs.h              |  6 ++
 src/mesa/drivers/dri/i965/brw_fs_generator.cpp  | 92 +++++++++++++++++--------
 src/mesa/drivers/dri/i965/brw_sf_emit.c         | 16 -----
 8 files changed, 98 insertions(+), 46 deletions(-)


More information about the mesa-dev mailing list