[Mesa-dev] [PATCH] i965/gen8: Emit color calculator state whenever viewport changes

[Pohjolainen, Topi]

On Mon, Jun 09, 2014 at 05:14:38PM +0300, Topi Pohjolainen wrote:
> Fixes es3 cts test framebuffer_blit_functionality_scissor_blit.test
> on bdw. Viewport changes are tracked by 'brw_cc_vp' which in turn
> signals CACHE_NEW_CC_VP that should be tracked by 'brw_cc_unit'. On
> gen4 this is the case but not on any newer.
> 
> For some reason gen5-7 don't suffer from the missing signaling.
> Perhaps one of the mesa states tracked by 'brw_cc_unit'
> (_NEW_STENCIL, _NEW_COLOR, _NEW_DEPTH, _NEW_BUFFERS) is
> sufficient. Or we are just lucky.

In fact it doesn't make any sense on > 4 - 'brw_cc_unit' is not
considered at all.

> 
> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_state_upload.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c b/src/mesa/drivers/dri/i965/brw_state_upload.c
> index 3a452c3..a06615a 100644
> --- a/src/mesa/drivers/dri/i965/brw_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/brw_state_upload.c
> @@ -261,6 +261,7 @@ static const struct brw_tracked_state *gen8_atoms[] =
>     &gen8_state_base_address,
>  
>     &brw_cc_vp,
> +   &brw_cc_unit,
>     &gen7_cc_viewport_state_pointer, /* must do after brw_cc_vp */
>     &gen8_sf_clip_viewport,
>  
> -- 
> 1.8.3.1
>