[Mesa-dev] [PATCH v2 2/6] i965/fs: skip copy-propate for logical instructions with negated src entries

Matt Turner mattst88 at gmail.com
Mon Jun 9 10:09:58 PDT 2014


On Thu, Jun 5, 2014 at 11:05 AM, Abdiel Janulgue
<abdiel.janulgue at linux.intel.com> wrote:
> The negation source modifier on src registers has changed meaning in Broadwell when
> used with logical operations. Don't copy propagate when negate src modifier is set
> and when the destination instruction is a logical op.
>
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue at linux.intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp
> index d3d59aa..aa506f5 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp
> @@ -42,6 +42,7 @@ namespace { /* avoid conflict with opt_copy_propagation_elements */
>  struct acp_entry : public exec_node {
>     fs_reg dst;
>     fs_reg src;
> +   enum opcode opcode;

This isn't used until the next patch, so it should be added in the next patch.


More information about the mesa-dev mailing list