[Mesa-dev] [PATCH v2 4/6] i965/vec4: skip copy-propate for logical instructions with negated src entries

Matt Turner mattst88 at gmail.com
Mon Jun 9 10:15:42 PDT 2014


On Thu, Jun 5, 2014 at 11:05 AM, Abdiel Janulgue
<abdiel.janulgue at linux.intel.com> wrote:
> The negation source modifier on src registers has changed meaning in Broadwell when
> used with logical operations. Don't copy propagate when negate src modifier is set
> and when the destination instruction is a logical op.
>
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue at linux.intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_vec4.h               |  4 +-
>  .../drivers/dri/i965/brw_vec4_copy_propagation.cpp | 68 +++++++++++++++-------
>  2 files changed, 49 insertions(+), 23 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.h
> index fd58b3c..51da46c 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4.h
> +++ b/src/mesa/drivers/dri/i965/brw_vec4.h
> @@ -228,6 +228,8 @@ writemask(dst_reg reg, unsigned mask)
>     return reg;
>  }
>
> +struct copy_entry;

I don't think this (specifically the new opcode field it was added
for) is used until the next patch?


More information about the mesa-dev mailing list