[Mesa-dev] [PATCH 04/15] glsl: Add preprocessor error condition for #else directive

Anuj Phogat anuj.phogat at gmail.com
Mon Jun 9 11:59:47 PDT 2014

On Mon, Jun 9, 2014 at 11:44 AM, Matt Turner <mattst88 at gmail.com> wrote:
> On Mon, Jun 9, 2014 at 11:40 AM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
>> On Fri, Jun 6, 2014 at 9:42 PM, Ian Romanick <idr at freedesktop.org> wrote:
>>> I thought Matt already fixed this bug.
>> A basic testing shows that below commit fixed the "garbage after #endif" bug
>> but "#garbage after #else" bug still exists. Absence of tests kept it untested.
> Strange. I see that commit added
> src/glsl/glcpp/tests/103-garbage-after-else.c that looks to still
> exist:
Yes. It exists.

> #if 0
> #else garbage
> #endif
> The Khronos test contains two tokens after #else. I'm not sure if that
> is the difference or not.
Khronos is testing many different cases. Failing case tests:

#if 1
#else garbage

I'll add this test case to glcpp/tests.

More information about the mesa-dev mailing list