[Mesa-dev] [PATCH 00/11] glsl: Remove unused includes found with IWYU

[Tom Stellard]

On Tue, Jun 10, 2014 at 12:57:31AM +0200, thomashelland90 at gmail.com wrote:
> From: Thomas Helland <thomashelland90 at gmail.com>
> 

For the series:

Reviewed-by: Tom Stellard <thomas.stellard at amd.com>

Do these patches make any measurable improvement in compile time?

-Tom
> This series removes some unused includes in the glsl-directory.
> These were found with Google's include-what-you-use plugin for clang.
> Patches have been compile-tested and a quick glxgears-run has been done.
> I have not done a full piglit-run, let me know if that's wanted.
> 
> Oh, and excuse me if I've messed up something.
> First run with git and mailing-lists, so lots to learn.
> 
> Thomas Helland (11):
>   glsl: Remove unused includes in link_uniform_init.
>   glsl: Remove unused includes in link_uniform_block_active_visitor.h
>   glsl: Remove unused include in ast_to_hir.cpp
>   glsl: Remove unused include from builtin_variables.cpp
>   glsl: Remove unused include from glsl_types.cpp
>   glsl: Remove unused include from glsl_symbol_table.h
>   glsl: Remove unused include from hir_field_selection.cpp
>   glsl: Remove unused include from ir_basic_block.cpp
>   glsl: Remove unused include from ir_constant_expression.cpp
>   glsl: Remove unused include in ir.cpp
>   glsl: Remove unused include in expr.flatt.
> 
>  src/glsl/ast_to_hir.cpp                      | 1 -
>  src/glsl/builtin_variables.cpp               | 1 -
>  src/glsl/glsl_symbol_table.h                 | 2 +-
>  src/glsl/glsl_types.cpp                      | 4 +---
>  src/glsl/hir_field_selection.cpp             | 1 -
>  src/glsl/ir.cpp                              | 1 -
>  src/glsl/ir_basic_block.cpp                  | 2 --
>  src/glsl/ir_constant_expression.cpp          | 1 -
>  src/glsl/ir_expression_flattening.cpp        | 2 --
>  src/glsl/link_uniform_block_active_visitor.h | 2 --
>  src/glsl/link_uniform_initializers.cpp       | 2 --
>  11 files changed, 2 insertions(+), 17 deletions(-)
> 
> -- 
> 2.0.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev