[Mesa-dev] [PATCH] meta: save and restore swizzle for _GenerateMipmap

Robert Bragg robert at sixbynine.org
Wed Jun 11 13:47:29 PDT 2014

On Tue, Jun 10, 2014 at 6:00 PM, Ian Romanick <idr at freedesktop.org> wrote:
> On 06/09/2014 07:48 AM, Robert Bragg wrote:
>> This makes sure to use a no-op swizzle while iteratively rendering each
>> level of a mipmap otherwise we may loose components and effectively
>> apply the swizzle twice by the time these levels are sampled.
> Right... the swizzle state shouldn't affect mipmap generation at all.
> One minor nit below, but otherwise
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> I second Chris's request for a piglit test.  It should be pretty easy to
> clone one of the existing tests/fbo/fbo-generatemipmap-*.c tests and
> modify it to test this case.

Thanks Chris and Ian for the review; I've landed the patch and sent a
test case to the piglit mailinglist.


More information about the mesa-dev mailing list