[Mesa-dev] [PATCH] Implement the ARB_clear_texture extension

[Ilia Mirkin]

On Thu, Jun 12, 2014 at 11:08 AM, Neil Roberts <neil at linux.intel.com> wrote:
>>> +   if (ctx->Version >= 30 || ctx->Extensions.EXT_texture_integer) {
>>> +      /* both source and dest must be integer-valued, or neither */
>>> +      if (_mesa_is_format_integer_color(texImage->TexFormat) !=
>>> +          _mesa_is_enum_format_integer(format)) {
>>
>> Also, is it possible to have a ctx->Version >= 30 &&
>> !EXT_texture_integer?
>
> No, but it is possible to to have EXT_texture_integer with
> ctx->Version<30 which presumably is what the expression is trying to
> catch.

The implicit suggestion was that this should just be

if (ctx->Extensions.EXT_texture_integer)

Since that will never be false for GL3+ contexts.

Agree with all your other responses/comments, BTW. Thanks for adding
all the tests; the invalid api usage one is the last one still
missing, I think.

Regarding your question about enabling the extension, perhaps it can
be done from where meta is set up? I'm not entirely sure how it
latches onto a context...

  -ilia