[Mesa-dev] [PATCH] llvmpipe: increase number of queries which can be binned simultaneously to 64

[Jose Fonseca]

----- Original Message -----
> From: Roland Scheidegger <sroland at vmware.com>
> 
> Gallium (but not OpenGL) does allow nesting of queries, but there's no
> limit specified (d3d10 has no limit neither). Nevertheless, for practical
> purposes we need some limit in llvmpipe, otherwise we'd need more complex
> handling of queries as we need to keep track of all binned queries (this
> only affects queries which gather data past setup). A limit of 16 is too
> small though, while 64 would suffice.
> ---
>  src/gallium/drivers/llvmpipe/lp_rast.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/llvmpipe/lp_rast.h
> b/src/gallium/drivers/llvmpipe/lp_rast.h
> index 6bd917d..c209f47 100644
> --- a/src/gallium/drivers/llvmpipe/lp_rast.h
> +++ b/src/gallium/drivers/llvmpipe/lp_rast.h
> @@ -66,7 +66,7 @@ struct cmd_bin;
>  /* Rasterizer output size going to jit fs, width/height */
>  #define LP_RASTER_BLOCK_SIZE 4
>  
> -#define LP_MAX_ACTIVE_BINNED_QUERIES 16
> +#define LP_MAX_ACTIVE_BINNED_QUERIES 64
>  
>  #define IMUL64(a, b) (((int64_t)(a)) * ((int64_t)(b)))
>  
> --
> 1.9.1
> 


Reviewed-by: Jose Fonseca <jfonseca at vmware.com>