[Mesa-dev] [PATCH 06/26] target-helpers: add a note about debug wrappers

Emil Velikov emil.l.velikov at gmail.com
Thu Jun 12 12:56:26 PDT 2014


If memory serves me right, at least one debug wrapper does
not return the base screen on failure.

Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
 src/gallium/auxiliary/target-helpers/inline_debug_helper.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/gallium/auxiliary/target-helpers/inline_debug_helper.h b/src/gallium/auxiliary/target-helpers/inline_debug_helper.h
index 77c7cfd..6fe667d 100644
--- a/src/gallium/auxiliary/target-helpers/inline_debug_helper.h
+++ b/src/gallium/auxiliary/target-helpers/inline_debug_helper.h
@@ -26,6 +26,10 @@
 #include "noop/noop_public.h"
 #endif
 
+/*
+ * TODO: Audit the following *screen_create() - all of
+ * them should return the original screen on failuire.
+ */
 static INLINE struct pipe_screen *
 debug_screen_wrap(struct pipe_screen *screen)
 {
-- 
1.9.3



More information about the mesa-dev mailing list