[Mesa-dev] [PATCH] Remove _mesa_is_type_integer and _mesa_is_enum_format_or_type_integer
brianp at vmware.com
Fri Jun 13 06:11:01 PDT 2014
On 06/12/2014 10:52 AM, Neil Roberts wrote:
> The comment for _mesa_is_type_integer is confusing because it says that it
> returns whether the type is an “integer (non-normalized)” format. I don't
> think it makes sense to say whether a type is normalized or not because it
> depends on what format it is used with. For example, GL_RGBA+GL_UNSIGNED_BYTE
> is normalized but GL_RGBA_INTEGER+GL_UNSIGNED_BYTE isn't. If the normalized
> comment is just a mistake then it still doesn't make much sense because it is
> missing the packed-pixel types such as GL_UNSIGNED_INT_5_6_5. If those were
> added then it effectively just returns type != GL_FLOAT.
> That function was only used in _mesa_is_enum_format_or_type_integer. This
> function effectively checks whether the format is non-normalized or the type
> is an integer. I can't think of any situation where that check would make
> As far as I can tell neither of these functions have ever been used anywhere
> so we should just remove them to avoid confusion.
> These functions were added in 9ad8f431b2a47060bf05517246ab0fa8d249c800.
> src/mesa/main/glformats.c | 30 ------------------------------
> src/mesa/main/glformats.h | 6 ------
> 2 files changed, 36 deletions(-)
Reviewed-by: Brian Paul <brianp at vmware.com>
Do you need someone to commit/push this?
More information about the mesa-dev