[Mesa-dev] [PATCH] meta_blit: properly compute texture width for the CopyTexSubImage fallback

Jordan Justen jljusten at gmail.com
Fri Jun 13 12:56:46 PDT 2014


On Fri, Jun 13, 2014 at 12:47 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> On Fri, Jun 13, 2014 at 12:20 PM, Brian Paul <brianp at vmware.com> wrote:
>> On 06/13/2014 01:17 PM, Jason Ekstrand wrote:
>>>
>>> ---
>>>   src/mesa/drivers/common/meta_blit.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/mesa/drivers/common/meta_blit.c
>>> b/src/mesa/drivers/common/meta_blit.c
>>> index aa12e04..2b99b99 100644
>>> --- a/src/mesa/drivers/common/meta_blit.c
>>> +++ b/src/mesa/drivers/common/meta_blit.c
>>> @@ -407,7 +407,7 @@ blitframebuffer_texture(struct gl_context *ctx,
>>>         }
>>>      } else {
>>>         GLenum tex_base_format;
>>> -      int srcW = abs(srcY1 - srcY0);
>>> +      int srcW = abs(srcX1 - srcX0);
>>>         int srcH = abs(srcY1 - srcY0);
>>>         /* Fall back to doing a CopyTexSubImage to get the destination
>>>          * renderbuffer into a texture.
>>>
>>
>> Reviewed-by: Brian Paul <brianp at vmware.com>
>>
>> I suspect this would apply to at least the 10.2 stable branch also.  So,
>> please tag with:
>>
>> Cc: mesa-stable at lists.freedesktop.org
>
> What do you mean?  Do you want me to re-send with the CC?  Forward?

Add this to the commit message before pushing. No need to re-send, as
there are scripts that scan the log.
Cc: "10.2" <mesa-stable at lists.freedesktop.org>

-Jordan


More information about the mesa-dev mailing list