[Mesa-dev] [PATCH] i965/vec4: Use the sampler for pull constant loads on Broadwell.

[Ben Widawsky]

On Sat, Jun 14, 2014 at 12:58:03PM -0700, Kenneth Graunke wrote:
> We've used the LD sampler message for pull constant loads on earlier
> hardware for some time, and also were already using it for the FS on
> Broadwell.  This patch makes us use it for Broadwell VS/GS as well.
> 
> I believe that when I wrote this code in 2012, we still used the data
> port in some cases, and I somehow neglected to convert it while
> rebasing.
> 
> Improves performance in GLBenchmark 2.7 Egypt by 416.978% +/- 2.25821%
> (n = 17).  Many other applications should benefit similarly: this speeds
> up uniform array access in the VS, which is commonly used for skinning
> shaders, among other things.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

My wins weren't quite so massive (I believe I have a slower part than
you): 143.064% +/- 0.955119%

Nevertheless, results confirmed. Excellent work, Ken!
Tested-by: Ben Widawsky <ben at bwidawsk.net>

-- 
Ben Widawsky, Intel Open Source Technology Center