[Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

[Matt Arsenault]

On Jun 17, 2014, at 3:11 PM, Bruno Jimenez <brunojimen at gmail.com> wrote:

> Hi,
> 
> I have a couple of questions about this patch:
> 
> 1) Could you please also change how the results of the
> 'CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE' and
> 'CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE' queries are generated?
> According to the spec, if 'cl_khr_fp64' is not supported, they should be
> 0.
> 



> 2) When llvm is invoked for compiling a module, a macro definition is
> added with:
> 'c.getPreprocessorOpts().addMacroDef("cl_khr_fp64");'
> Is it ok to use this macro always or should it only be used when
> 'cl_khr_fp64' is supported?

It should only be added when supported. The most common way of testing for double support is ifdef cl_khr_fp64