[Mesa-dev] [PATCH] glx: Add an error message when a direct renderer's createScreen() routine fails because no matching fbConfigs or visuals could be found.

[Kenneth Graunke]

On Tuesday, June 10, 2014 10:51:40 AM Jon TURNEY wrote:
> Nearly all the error cases in *createScreen() issue an error message to 
diagnose
> the failure to initialize before branching to handle_error.  The few 
remaining
> error cases which don't should probably do the same.
> 
> (At the moment, it seems this can be triggered in drisw with an X server 
which
> reports definite values for MAX_PBUFFFER_(WIDTH|HEIGHT|SIZE), because those
> attributes are checked for an exact match against 0.)
> 
> Signed-off-by: Jon TURNEY <jon.turney at dronecode.org.uk>

Yes, please!  I've hit cases where the X server loads a different DRI driver 
than the client, and they disagree on visuals, so things just fail.  It 
doesn't happen too often, but when it does, it can be quite bewildering.  More 
error messages are definitely welcome.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140617/bb18ac86/attachment.sig>