[Mesa-dev] [PATCH v2 20/23] i965: Enable vertex streams up to MAX_VERTEX_STREAMS.

Kenneth Graunke kenneth at whitecape.org
Wed Jun 18 14:00:05 PDT 2014


On Wednesday, June 18, 2014 01:45:52 PM Ian Romanick wrote:
> On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote:
> > ---
> >  src/mesa/drivers/dri/i965/brw_context.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/src/mesa/drivers/dri/i965/brw_context.c 
b/src/mesa/drivers/dri/i965/brw_context.c
> > index cfb0be0..6ba58d3 100644
> > --- a/src/mesa/drivers/dri/i965/brw_context.c
> > +++ b/src/mesa/drivers/dri/i965/brw_context.c
> > @@ -507,6 +507,10 @@ brw_initialize_context_constants(struct brw_context 
*brw)
> >        ctx->Const.ViewportBounds.Min = -(float)ctx-
>Const.MaxViewportWidth;
> >        ctx->Const.ViewportBounds.Max = ctx->Const.MaxViewportWidth;
> >     }
> > +
> > +   /* ARB_gpu_shader5 */
> > +   if (brw->gen >= 7)
> > +      ctx->Const.MaxVertexStreams = MAX_VERTEX_STREAMS;
> 
> I'd rather have this be MIN2(4, MAX_VERTEX_STREAMS).  That way
> increasing MAX_VERTEX_STREAMS to support some new hardware won't break GEN7.

That seems like a good idea.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140618/a9d9699f/attachment.sig>


More information about the mesa-dev mailing list