[Mesa-dev] [PATCH v2 22/23] mesa: Init Geom.UsesEndPrimitive in shader programs.
Ian Romanick
idr at freedesktop.org
Thu Jun 19 15:23:20 PDT 2014
On 06/18/2014 11:30 PM, Iago Toral wrote:
> On Wed, 2014-06-18 at 13:48 -0700, Ian Romanick wrote:
>> I think this patch and 23 should be moved first in the series... the can
>> certainly land before the other patches in the series.
>
> Right. I'll push these two tomorrow if nobody says otherwise today.
>
> Since you marked patch 23 for stable: do I need to do something else
> other than adding the CC tag in the commit message? Should I send the
> patch also to mesa-stable at lists.freedesktop.org?
Just copy-and-paste the Cc line that I put in the review. Branch
maintainers use scripts to find candidate patches in the master branch.
> Iago
>
>> This patch is
>>
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>>
>> On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote:
>>> ---
>>> src/mesa/main/shaderobj.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/src/mesa/main/shaderobj.c b/src/mesa/main/shaderobj.c
>>> index 03db862..b3d428c 100644
>>> --- a/src/mesa/main/shaderobj.c
>>> +++ b/src/mesa/main/shaderobj.c
>>> @@ -248,6 +248,7 @@ _mesa_init_shader_program(struct gl_context *ctx, struct gl_shader_program *prog
>>> prog->Geom.VerticesOut = 0;
>>> prog->Geom.InputType = GL_TRIANGLES;
>>> prog->Geom.OutputType = GL_TRIANGLE_STRIP;
>>> + prog->Geom.UsesEndPrimitive = GL_FALSE;
>>> prog->Geom.UsesStreams = GL_FALSE;
>>>
>>> prog->TransformFeedback.BufferMode = GL_INTERLEAVED_ATTRIBS;
>>>
More information about the mesa-dev
mailing list