[Mesa-dev] [PATCH] targets/(vdpau|xvmc): hardlink against the installed library

[Emil Velikov]

On 23/06/14 19:58, Andy Furniss wrote:
> Emil Velikov wrote:
>> Previous two commits, resolved the symlink generation required
>> by the versioning of the library and incorrectly changed the
>> way hardlinks are created by linking the ones from the build
>> tree. If the device used for building differs from the one
>> set as destination linking will fail.
>>
>> Reported-by: Andy Furniss <adf.lists at gmail.com>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>
>> Andy does this fixes the problem ?
> 
> I still don't get libvdpau_gallium installed.
> 
Not sure what made you believe that libvdpau_gallium should be installed, but
that truly is not the case.

> I do with this get the usual one installed properly now -
> 
> ls -lh /usr/lib/vdpau/
> total 11M
> lrwxrwxrwx 1 root root   26 Jun 23 19:17 libvdpau_radeonsi.so ->
> libvdpau_radeonsi.so.1.0.0
> lrwxrwxrwx 1 root root   26 Jun 23 19:17 libvdpau_radeonsi.so.1 ->
> libvdpau_radeonsi.so.1.0.0
> lrwxrwxrwx 1 root root   26 Jun 23 19:17 libvdpau_radeonsi.so.1.0 ->
> libvdpau_radeonsi.so.1.0.0
> -rwxr-xr-x 1 root root  11M Jun 23 19:17 libvdpau_radeonsi.so.1.0.0
> -rwxr-xr-x 1 root root  987 Jun 23 15:51 libvdpau_trace.la
> lrwxrwxrwx 1 root root   23 Jun 23 15:51 libvdpau_trace.so ->
> libvdpau_trace.so.1.0.0
> lrwxrwxrwx 1 root root   23 Jun 23 15:51 libvdpau_trace.so.1 ->
> libvdpau_trace.so.1.0.0
> -rwxr-xr-x 1 root root 173K Jun 23 15:51 libvdpau_trace.so.1.0.0
> 
Great thanks for reporting and testing.

> Making install in gallium/targets
> make[2]: Entering directory '/mnt/sdb1/Src64/Mesa-git/mesa/src/gallium/targets'
> Making install in vdpau
> make[3]: Entering directory
> '/mnt/sdb1/Src64/Mesa-git/mesa/src/gallium/targets/vdpau'
>   GEN      all-local
> make[4]: Entering directory
> '/mnt/sdb1/Src64/Mesa-git/mesa/src/gallium/targets/vdpau'
> make[4]: Nothing to be done for 'install-exec-am'.
>  /bin/mkdir -p '/usr/lib/vdpau'
>  /bin/sh ../../../../libtool   --mode=install /bin/install -c
> libvdpau_gallium.la '/usr/lib/vdpau'
> libtool: install: /bin/install -c .libs/libvdpau_gallium.so.1.0.0
> /usr/lib/vdpau/libvdpau_gallium.so.1.0.0
> libtool: install: (cd /usr/lib/vdpau && { ln -s -f libvdpau_gallium.so.1.0.0
> libvdpau_gallium.so.1 || { rm -f libvdpau_gallium.so.1 && ln -s
> libvdpau_gallium.so.1.0.0 libvdpau_gallium.so.1; }; })
> libtool: install: (cd /usr/lib/vdpau && { ln -s -f libvdpau_gallium.so.1.0.0
> libvdpau_gallium.so || { rm -f libvdpau_gallium.so && ln -s
> libvdpau_gallium.so.1.0.0 libvdpau_gallium.so; }; })
> libtool: install: /bin/install -c .libs/libvdpau_gallium.lai
> /usr/lib/vdpau/libvdpau_gallium.la
> libtool: finish: PATH="/sbin:/bin:/usr/sbin:/usr/bin:/sbin" ldconfig -n
> /usr/lib/vdpau
> ----------------------------------------------------------------------
> Libraries have been installed in:
>    /usr/lib/vdpau
> 
> If you ever happen to want to link against installed libraries
> in a given directory, LIBDIR, you must either use libtool, and
> specify the full pathname of the library, or use the `-LLIBDIR'
> flag during linking and do at least one of the following:
>    - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
>      during execution
>    - add LIBDIR to the `LD_RUN_PATH' environment variable
>      during linking
>    - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
>    - have your system administrator add LIBDIR to `/etc/ld.so.conf'
> 
> See any operating system documentation about shared libraries for
> more information, such as the ld(1) and ld.so(8) manual pages.
> ----------------------------------------------------------------------
One should never link against the vdpau backends so we can ignore the above
message.

I'm assuming that vdpau works as expected now ?

Cheers
Emil

> make  install-data-hook
> make[5]: Entering directory
> '/mnt/sdb1/Src64/Mesa-git/mesa/src/gallium/targets/vdpau'
>   GEN      install-data-hook
> make[5]: Leaving directory
> '/mnt/sdb1/Src64/Mesa-git/mesa/src/gallium/targets/vdpau'
> make[4]: Leaving directory
> '/mnt/sdb1/Src64/Mesa-git/mesa/src/gallium/targets/vdpau'
> make[3]: Leaving directory
> '/mnt/sdb1/Src64/Mesa-git/mesa/src/gallium/targets/vdpau'
> 
>