[Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

[Ilia Mirkin]

On Tue, Jun 24, 2014 at 12:58 PM, Tobias Droste <tdroste at gmx.de> wrote:
> Am Di, 24. Juni 2014, 12:46:39 schrieb Ilia Mirkin:
>> On Tue, Jun 24, 2014 at 12:44 PM, Tobias Droste <tdroste at gmx.de> wrote:
>> > Hi,
>> >
>> > this does not seem to work on r600g (or I'm too stupid ;-)).
>> > I updated to latest mesa master, patched piglit and this is the result:
>> >
>> > $ glxinfo
>> > [...]
>> > OpenGL vendor string: X.Org
>> > OpenGL renderer string: Gallium 0.4 on AMD JUNIPER
>> > OpenGL core profile version string: 3.3 (Core Profile) Mesa 10.3.0-devel
>> > (git-0c181cd)
>> > OpenGL core profile shading language version string: 3.30
>> > OpenGL core profile context flags: (none)
>> > OpenGL core profile profile mask: core profile
>> > [...]
>> >
>> > $ MESA_EXTENSION_OVERRIDE=GL_ARB_fragment_layer_viewport bin/shader_runner
>> > tests/spec/arb_fragment_layer_viewport/layer-gs-write-simple.shader_test
>> > -fbo -auto
>> > piglit: info: Requested an OpenGL 3.2 Core Context, and received a
>> > matching
>> > 3.3 context
>> >
>> > Probe color at (0,0)
>> >
>> >   Expected: 0.000000 1.000000 0.000000
>> >   Observed: 1.000000 0.000000 0.000000
>> >
>> > PIGLIT: {'result': 'fail' }
>> >
>> > $ MESA_EXTENSION_OVERRIDE=GL_ARB_fragment_layer_viewport bin/shader_runner
>> > tests/spec/arb_fragment_layer_viewport/viewport-gs-write-simple.shader_tes
>> > t - fbo -auto
>> > piglit: info: Requested an OpenGL 3.2 Core Context, and received a
>> > matching
>> > 3.3 context
>> >
>> > Probe color at (0,0)
>> >
>> >   Expected: 0.000000 1.000000 0.000000
>> >   Observed: 1.000000 0.000000 0.000000
>> >
>> > PIGLIT: {'result': 'fail' }
>>
>> Boooo :(
>>
>> Could I trouble you to figure out which of the 4 draws (in each) is
>> failing? (Just comment out the "probe" lines, leaving only one in for
>> each)
>>
>> Thanks for testing, BTW!
>>
>>   -ilia
>
> All 4 probes in each test fail with the same result:
> Expected: 0.000000 1.000000 0.000000
> Observed: 1.000000 0.000000 0.000000
>
> (And just to make sure I'm doing the right thing, I removed all 4 probes in
> each test and then it passes).

Marek, any idea what's missing? If this is easily fixed, would be nice
to avoid the cap.

Looking at r600_spi_pid, it seems like layer/viewport index are
handled "differently", which presumably means they must be handled
"differently" on the ps end as well.

  -ilia