[Mesa-dev] [Bug 80561] New: Incorrect implementation of some VDPAU APIs.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80561

          Priority: medium
            Bug ID: 80561
          Assignee: mesa-dev at lists.freedesktop.org
           Summary: Incorrect implementation of some VDPAU APIs.
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: jyavenard at gmail.com
          Hardware: Other
            Status: NEW
           Version: 10.2
         Component: Mesa core
           Product: Mesa

The issue appears to be in at least two functions

For both VdpOutputSurfaceRenderOutputSurface and
VdpOutputSurfaceRenderBitmapSurface

According to NVIDIA's documentation:
ftp://download.nvidia.com/XFree86/vdpau/doxygen/html/group___vdp_output_surface_render.html#gaf69e77f4d465d059341477a74ccebcd5

"source_surface     The source surface for the compositing operation. The
surface is treated as having four components: red, green, blue and alpha. Any
missing components are treated as 1.0. For example, for an A8 VdpBitmapSurface,
alpha will come from the surface but red, green and blue will be treated as
1.0. If source_surface is NULL, all components will be treated as 1.0. Note
that destination_surface and source_surface must have been allocated via the
same VdpDevice."

The key point being: "If source_surface is NULL, all components will be treated
as 1.0"

However, mesa's vdpau immediately returns an error if the VdpBitmapSurface is
invalid.

NULL provided as a parameter, be it a video surface or a bitmap surface usually
have a specific meaning, and doesn't always signify an error

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140626/5fb0fefe/attachment-0001.html>