[Mesa-dev] [PATCH 21/23] glsl/glcpp: Add test for a multi-line comment within an #if 0 block

Carl Worth cworth at cworth.org
Thu Jun 26 15:19:21 PDT 2014

This test is written to exercise a bug which I recently wrote, (but
fortunately caught and fixed before ever committing it).

For the curious:

  The bug happened when the NEWLINE_CATCHUP code didn't actually return the
  NEWLINE token (due to the skipping). This resulted in the lexer continuing
  on through all the subsequent rules while still in the NEWLINE_CATCHUP start
  condition, (which then triggered the internal-compiler-error catch-all

  What is intended is for the return of the NEWLINE token to start a new
  iteration of the lexer loop, at which time the NEWLINE_CATCHUP-handling code
  will reset from the <NEWLINE_CATCHUP> to the <INITIAL> start condition.
 src/glsl/glcpp/tests/137-multi-line-comment-in-if-0.c          | 7 +++++++
 src/glsl/glcpp/tests/137-multi-line-comment-in-if-0.c.expected | 7 +++++++
 2 files changed, 14 insertions(+)
 create mode 100644 src/glsl/glcpp/tests/137-multi-line-comment-in-if-0.c
 create mode 100644 src/glsl/glcpp/tests/137-multi-line-comment-in-if-0.c.expected

diff --git a/src/glsl/glcpp/tests/137-multi-line-comment-in-if-0.c b/src/glsl/glcpp/tests/137-multi-line-comment-in-if-0.c
new file mode 100644
index 0000000..38967dc
--- /dev/null
+++ b/src/glsl/glcpp/tests/137-multi-line-comment-in-if-0.c
@@ -0,0 +1,7 @@
+#if 0
+ * This multi-line comment needs to be 3 lines to test what's intended.
+ */
diff --git a/src/glsl/glcpp/tests/137-multi-line-comment-in-if-0.c.expected b/src/glsl/glcpp/tests/137-multi-line-comment-in-if-0.c.expected
new file mode 100644
index 0000000..0d6ef4d
--- /dev/null
+++ b/src/glsl/glcpp/tests/137-multi-line-comment-in-if-0.c.expected
@@ -0,0 +1,7 @@

More information about the mesa-dev mailing list