[Mesa-dev] [PATCH] dispatch: Do not generate extraneous parentheses.

Vinson Lee vlee at freedesktop.org
Thu Jun 26 22:24:44 PDT 2014


This patch fixes 592 clang parentheses-equality warnings on Fedora 20.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
---
 tests/util/piglit-dispatch-gen.c.mako | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/tests/util/piglit-dispatch-gen.c.mako b/tests/util/piglit-dispatch-gen.c.mako
index 772d936..16f9b17 100644
--- a/tests/util/piglit-dispatch-gen.c.mako
+++ b/tests/util/piglit-dispatch-gen.c.mako
@@ -31,23 +31,30 @@ resolve_${f0.name}(void)
 {
 % for req in alias_set.requirements:
 >-------/* ${req.command.name} (${req.provider.name}) */
-% for api in sorted(set(dispatch.APIS[x] for x in req.apis)):
+<% apis = sorted(set(dispatch.APIS[x] for x in req.apis)) %>
+% for api in apis:
 % if loop.first:
->-------if ((
-% else:
->-------     .
+>-------if (
+% if req.has_extension:
+............(
+% endif
+% endif
+% if len(apis) > 1:
+............(
 % endif
-.............(dispatch_api == ${api.c_piglit_token}
+.............dispatch_api == ${api.c_piglit_token}
 % if req.has_feature and req.feature.version_int > api.base_version_int:
 ................................................... && check_version(${req.feature.version_int})
 % endif
+% if len(apis) > 1:
 ................................................................................................)
+% endif
 % if not loop.last:
-................................................................................................. ||
+................................................................................................. || .
 % endif
 % endfor
-....................................................................................................)
 % if req.has_extension:
+....................................................................................................)
 >-------    && check_extension("${req.extension.name}")
 % endif
 ...............................................................) {
-- 
1.9.1



More information about the mesa-dev mailing list