[Mesa-dev] [PATCH] Remove the ATI_envmap_bumpmap extension

[Jason Ekstrand]

On Fri, Jun 27, 2014 at 5:41 PM, Chris Forbes <chrisf at ijw.co.nz> wrote:

> On Sat, Jun 28, 2014 at 10:19 AM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
>
> > @@ -653,135 +613,6 @@ _swrast_texture_span( struct gl_context *ctx,
> SWspan *span )
> [snip]
>
> > -
> > -   /*
> > -    * Must do all texture sampling before combining in order to
> > -    * accomodate GL_ARB_texture_env_crossbar.
> > -    */
> > -   for (unit = 0; unit < ctx->Const.MaxTextureUnits; unit++) {
> > -      const struct gl_texture_unit *texUnit = &ctx->Texture.Unit[unit];
> > -      if (texUnit->_Current &&
> > -          texUnit->_CurrentCombine->ModeRGB != GL_BUMP_ENVMAP_ATI) {
>
> You're ripping out the non-bump case here too...
>

Good Catch, thanks.
--Jason Ekstrand


>
> > -         const GLfloat (*texcoords)[4] = (const GLfloat (*)[4])
> > -            span->array->attribs[VARYING_SLOT_TEX0 + unit];
> > -         const struct gl_texture_object *curObj = texUnit->_Current;
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140627/000e8489/attachment-0001.html>