[Mesa-dev] [PATCH] clover: Fix building with latest llvm

Tom Stellard tom at stellard.net
Mon Mar 3 08:15:43 PST 2014


On Mon, Mar 03, 2014 at 08:05:26AM -0800, Tom Stellard wrote:
> On Sat, Mar 01, 2014 at 11:51:24PM +0100, Bruno Jiménez wrote:
> > Recently, llvm has changed to use c++11, so we also should use it
> > ---
> >  src/gallium/state_trackers/clover/Makefile.am | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/gallium/state_trackers/clover/Makefile.am b/src/gallium/state_trackers/clover/Makefile.am
> > index ece2b38..cc9311c 100644
> > --- a/src/gallium/state_trackers/clover/Makefile.am
> > +++ b/src/gallium/state_trackers/clover/Makefile.am
> > @@ -37,7 +37,7 @@ libcltgsi_la_SOURCES = \
> >  	tgsi/compiler.cpp
> >  
> >  libclllvm_la_CXXFLAGS = \
> > -	-std=c++98 \
> > +	-std=c++11 \
> >  	$(VISIBILITY_CXXFLAGS) \
> >  	$(LLVM_CPPFLAGS) \
> >  	$(DEFINES) \
> 
> I just sent out a patch which fixes this and doesn't break older versions:
> http://lists.freedesktop.org/archives/mesa-dev/2014-March/055191.html
> 

Sorry, I missed your updated version of this patch.  Your v2 looks better
than what I did.

-Tom

> > @@ -49,7 +49,7 @@ libclllvm_la_SOURCES = \
> >  	llvm/invocation.cpp
> >  
> >  libclover_la_CXXFLAGS = \
> > -	-std=c++0x \
> > +	-std=c++11 \
> >  	$(VISIBILITY_CXXFLAGS)
> >  
> 
> Can you resubmit this hunk as a separate patch.
> 
> Thanks,
> Tom
> 
> >  libclover_la_LIBADD = \
> > -- 
> > 1.9.0
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list