[Mesa-dev] [PATCH 04/20] automake: make install-lib-links less chatty

Emil Velikov emil.l.velikov at gmail.com
Wed Mar 5 03:42:27 PST 2014


On 05/03/14 10:13, Erik Faye-Lund wrote:
> On Tue, Mar 4, 2014 at 10:12 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> There is little point in echoing everything that the script does
>> to stdout. Wrap it in AM_V_GEN so that a reasonable message is
>> printed as a indication of it's invocation.
>>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>  install-lib-links.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/install-lib-links.mk b/install-lib-links.mk
>> index 73d9e14..9dd4c30 100644
>> --- a/install-lib-links.mk
>> +++ b/install-lib-links.mk
>> @@ -4,7 +4,7 @@
>>  all-local : .libs/install-mesa-links
>>
>>  .libs/install-mesa-links : $(lib_LTLIBRARIES)
>> -       $(MKDIR_P) $(top_builddir)/$(LIB_DIR)
>> +       $(AM_V_GEN)$(MKDIR_P) $(top_builddir)/$(LIB_DIR);       \
> 
> GEN for a directory, really? Why not $(AM_V_at)?
> 
Notice the trailing backspace, which will wrap the whole script in GEN.
One could use AM_V_at for the folder and AM_V_GEN (or other) for the
link/copy. IMHO the latter may be an overkill but meh...

-Emil


More information about the mesa-dev mailing list