[Mesa-dev] [PATCH 1/3] radeon: Rename struct radeon_llvm_binary to radeon_shader_binary

Michel Dänzer michel at daenzer.net
Wed Mar 5 18:57:29 PST 2014


On Mit, 2014-03-05 at 21:25 -0500, Tom Stellard wrote:
> And move its definition into r600_pipe_common.h;  This struct is a just
> a container for shader code and has nothing to do with LLVM.

Well, it has something to do with LLVM in that the drivers only use it
with LLVM. :)


> diff --git a/src/gallium/drivers/radeon/Makefile.am b/src/gallium/drivers/radeon/Makefile.am
> index 7971191..b521658 100644
> --- a/src/gallium/drivers/radeon/Makefile.am
> +++ b/src/gallium/drivers/radeon/Makefile.am
> @@ -17,6 +17,7 @@ noinst_LTLIBRARIES += libllvmradeon.la
>  
>  libllvmradeon_la_CFLAGS = \
>  	$(GALLIUM_DRIVER_CFLAGS) \
> +	$(RADEON_CFLAGS) \
>  	$(LLVM_CFLAGS)
>  
>  libllvmradeon_la_SOURCES = \

Should this be a separate change?


Other than that, patches 1 and 2 are

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer



More information about the mesa-dev mailing list