[Mesa-dev] [PATCH] gbm: make 'devices' array static

[Emil Velikov]

On 03/03/14 17:31, Julien Cristau wrote:
> On Mon, Mar  3, 2014 at 17:29:56 +0000, Emil Velikov wrote:
> 
>> On 03/03/14 17:23, Julien Cristau wrote:
>>> On Mon, Mar  3, 2014 at 17:21:15 +0000, Emil Velikov wrote:
>>>
>>>> On 03/03/14 16:41, Julien Cristau wrote:
>>>>> It's only used in this one file as far as I can tell, and exporting a
>>>>> symbol named 'devices' from a shared library is a recipe for trouble.
>>>> Hmm did you really get the 'devices' exported symbol, or did you notice
>>>> this while going through the code ? Either way this looks good afaict
>>>>
>>> The former:
>>> $ objdump -T /usr/lib/x86_64-linux-gnu/libgbm.so.1 | grep devices
>>> 0000000000206360 g    DO .bss   0000000000000080  Base        devices
>>>
>> I'm guessing that this is from 10.1-rcx or earlier. All of the libgbm
>> exported symbol mayhem is resolved in master. A few other libraries have
>> been updated as well :-)
>>
> Right, I noticed the issue with at least 9.2, 10.0 and 10.1-rc.  Good to
> know it's improved in master.
> 
Pushed to master, thanks again for the patch.

-Emil
> Cheers,
> Julien
>