[Mesa-dev] [PATCH 4/4] mesa: stop aliasing ARB and core shader API functions

[Emil Velikov]

On 10/03/14 14:50, Brian Paul wrote:
> On 03/09/2014 02:30 PM, Emil Velikov wrote:
>> On 09/03/14 01:10, Brian Paul wrote:
>>> For example, we now we have separate dispatch functions for
>>> glCompileShader(GLuint) and glCompileShaderARB(GLhandleARB).
>>>
>>> With this change and the previous ones we should be able to build/run
>>> on MacOS again (where GLhandleARB is a void pointer, not a GLuint).
>>>
>> Hi Brian,
>>
>> Wondering if with the drop of the aliases one would need to update the
>> gl function tables in dispatch_sanity.cpp. AFAICS it currently checks
>> the non ARB functions but does not list the ARB ones (unlike other
>> aliased functions).
>
> I missed dispatch_sanity.cpp.  I've added the new ARB entrypoints but
> AFAICT, dispatch_sanity.cpp isn't even getting compiled.  The other
> 'make check' tests seem to get built and run, but not that one.  I don't
> know whats up with that.
>
Quite possible, dispatch_sanity.cpp is only build if you have shared glapi.

With that said the make check nicely catches the problem, and 
unfortunately it still complains with your follow up patch :'(

>
>> Are they any special (apart from the ifdef APPLE piece in the spec) ?
>
> Can you clarify that?
>
Feel free to ignore that, I've checked through the spec and answered by 
half complete question.

-Emil
> -Brian
>
>