[Mesa-dev] [PATCH 02/10] i965: Drop broken front_buffer_reading/drawing optimization.

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/09/2014 09:04 PM, Kenneth Graunke wrote:
> On 03/04/2014 02:17 PM, Eric Anholt wrote:
>> The flag wasn't getting updated correctly when the
>> ctx->DrawBuffer or ctx->ReadBuffer changed.  It usually ended up
>> working out because most apps only have one window system
>> framebuffer, or if they have more than one and they have any
>> front read/drawing, they will have called 
>> glReadBuffer()/glDrawBuffer() on it when they get started on the
>> new buffer.
> 
> Yep, it sure doesn't look like they're getting updated when the
> buffers change.  I like your fix here.
> 
> Patches 1-4 are: Reviewed-by: Kenneth Graunke
> <kenneth at whitecape.org>

They are also

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I'm still working through the others... and Ken's comments on them.

> _______________________________________________ mesa-dev mailing
> list mesa-dev at lists.freedesktop.org 
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iEYEARECAAYFAlMeOVoACgkQX1gOwKyEAw8olACeNkXRu0W73/L1T7mpyAUCRdTX
x5EAnjym2IfxElDUHcs8ZP3awV3/T117
=dg6G
-----END PGP SIGNATURE-----