[Mesa-dev] [PATCH] mesa-demos: fix opengles1/texture_from_pixmap test

Tapani Pälli tapani.palli at intel.com
Mon Mar 10 23:28:44 PDT 2014


On 03/10/2014 06:05 PM, Chia-I Wu wrote:
> On Fri, Mar 7, 2014 at 6:56 PM, Tapani Pälli <tapani.palli at intel.com> wrote:
>> Remove GL_OES_EGL_image_external usage, this would work with current
>> Mesa only if image was created with EGL_EXT_image_dma_buf_import, this
>> makes test work again also if GL_OES_EGL_image_external is present.
> Can we make the use of GL_OES_EGL_image_external optional, with a
> command line option or etc?  Though I don't have a strong opinion.
>

I see, this test works for other drivers as the restriction with dma_buf
is imposed only by the Intel driver, not in core. Maybe better just
forget about this patch.

>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> ---
>>  src/egl/opengles1/texture_from_pixmap.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/src/egl/opengles1/texture_from_pixmap.c b/src/egl/opengles1/texture_from_pixmap.c
>> index eeb6ee7..436e575 100644
>> --- a/src/egl/opengles1/texture_from_pixmap.c
>> +++ b/src/egl/opengles1/texture_from_pixmap.c
>> @@ -351,11 +351,6 @@ app_init_exts(struct app_data *data)
>>     if (exts && data->glEGLImageTargetTexture2DOES) {
>>        if (strstr(exts, "GL_OES_EGL_image"))
>>           data->target = GL_TEXTURE_2D;
>> -#ifdef GL_OES_EGL_image_external
>> -      /* prefer external texture */
>> -      if (strstr(exts, "GL_OES_EGL_image_external"))
>> -         data->target = GL_TEXTURE_EXTERNAL_OES;
>> -#endif
>>     }
>>
>>     if (!data->target) {
>> --
>> 1.8.3.1
>>
>
>



More information about the mesa-dev mailing list