[Mesa-dev] [PATCH] mesa: mark GL_RGB9_E5 as not color-renderable

[Ian Romanick]

On 03/09/2014 05:10 PM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> The GL 4.4 spec says it's not color-renderable and not accepted
> by RenderBufferStorage. The EXT_texture_shared_exponent spec says
> it's not color-renderable but it's accepted by RenderBufferStorageEXT.
> This seems to be a bug in the extension spec.
> 
> Let's do what GL 4.4 says.

I believe the intention was that someone could make it renderable, but
most implemenations would generate GL_FRAMEBUFFER_UNSUPPORTED.  That
must have been corrected when it was pulled into core.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

Some drivers may need follow-up patches to clean out code that generated
GL_FRAMEBUFFER_UNSUPPORTED for this format.

> Cc: mesa-stable at lists.freedesktop.org
> ---
>  src/mesa/main/fbobject.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index a9dcc51..dfe2f1e 100644
> --- a/src/mesa/main/fbobject.c
> +++ b/src/mesa/main/fbobject.c
> @@ -1565,10 +1565,6 @@ _mesa_base_fbo_format(struct gl_context *ctx, GLenum internalFormat)
>        return ctx->API == API_OPENGL_COMPAT &&
>               ctx->Extensions.ARB_texture_float &&
>               ctx->Extensions.ARB_framebuffer_object ? GL_INTENSITY : 0;
> -   case GL_RGB9_E5:
> -      return (_mesa_is_desktop_gl(ctx)
> -              && ctx->Extensions.EXT_texture_shared_exponent)
> -         ? GL_RGB : 0;
>     case GL_R11F_G11F_B10F:
>        return ((_mesa_is_desktop_gl(ctx) && ctx->Extensions.EXT_packed_float) ||
>                _mesa_is_gles3(ctx) /* EXT_color_buffer_float */ )