[Mesa-dev] i965: Pull parameters in SIMD16 mode.

Ian Romanick idr at freedesktop.org
Wed Mar 12 10:54:39 PDT 2014


Patches 1 through 4 and 8 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I don't know the code well enough to give any evaluation of patch 5, and
all the others really depend on 5.

On 03/11/2014 11:48 PM, Kenneth Graunke wrote:
> Hello,
> 
> This series adds support for pull constants in SIMD16 mode.  By the end
> of the series, shader-db gains 78 extra SIMD16 programs, and the net
> code change is -39 lines.  In short:
> 
>    <anholt> better living through deleting code.
> 
> Most of the work in this series is refactoring the code to change how
> information about locations is tracked and how it flows between functions.
> Overall, I think it's much nicer at the end (though I'm clearly biased).
> 
> This is available in the 'pull16-v12' branch of ~kwg/mesa.  I tested it
> for Piglit regressions and shader-db code quality regressions at every
> single commit---getting a patch series that didn't regress at any point
> was kind of tricky.  Lots of obviously correct code would break
> horribly...hence the 12 branch revisions. :)
> 
> --Ken
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev



More information about the mesa-dev mailing list