[Mesa-dev] [PATCH] i965: Delete "fast color clear unsupported" performance warning.

[Ian Romanick]

On 03/13/2014 02:41 AM, Kenneth Graunke wrote:
> Applications frequently clear to colors other than 0.0 or 1.0, which
> prevents us from doing fast color clears.  In that case, we issue this
> performance warning on basically every glClear call, resulting in so
> much spam that it's nearly impossible to see any other messages.
> 
> Plus, I don't think it's useful.  We aren't suggesting a better way to
> do what the application developers want---we're just telling them it
> would be faster to do something they don't want.
> 
> Driver developers have no control over the clear color, so this message
> is totally useless to them.

I can go along with this logic.  If we still want a message like this,
we'd want a perf_debug_once kind of thing.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp b/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
> index 76f8299..3a96106 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
> @@ -155,8 +155,6 @@ is_color_fast_clear_compatible(struct brw_context *brw,
>  
>     for (int i = 0; i < 4; i++) {
>        if (color->f[i] != 0.0 && color->f[i] != 1.0) {
> -         perf_debug("Clear color unsupported by fast color clear.  "
> -                    "Falling back to slow clear.\n");
>           return false;
>        }
>     }
>