[Mesa-dev] [PATCH 5/8] i965/upload: Actually comment the upload code.

[Kenneth Graunke]

On 03/13/2014 09:05 AM, Ian Romanick wrote:
> On 03/13/2014 01:57 AM, Kenneth Graunke wrote:
>> diff --git a/src/mesa/drivers/dri/i965/intel_upload.c b/src/mesa/drivers/dri/i965/intel_upload.c
>> index ec3109b..c767b7d 100644
>> --- a/src/mesa/drivers/dri/i965/intel_upload.c
>> +++ b/src/mesa/drivers/dri/i965/intel_upload.c
>> @@ -25,7 +25,16 @@
>>  /**
>>   * @file intel_upload.c
>>   *
>> - * Batched upload via BOs.
>> + * A batched data upload mechanism which can efficiently copy user supplied
>> + * data into buffer objects.
>> + *
>> + * OpenGL allows applications to provide data in user arrays, which may
>> + * disappear or change contents at any time.  The GPU can't use this memory
>> + * directly, so we need to copy it into buffer objects.
>> + *
>> + * Often times, the amount of data we need to copy is small.  On non-LLC
>> + * platforms, it's more efficient to stage this data in a CPU-sized buffer
>                                                                  ^^^^^
> Is sized the word you mean here?  Or should it be CPU-side?

No, I meant a literally 22nm sized buffer... :)

Fixed, thanks.

--Ken



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140313/22279a2b/attachment.pgp>