[Mesa-dev] nouveau_vieux loading broken in 10.1

[Ilia Mirkin]

On Mon, Mar 17, 2014 at 9:30 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Hello,
>
> Starting with
>
> commit 7bd95ec437a5b1052fa17780a9d66677ec1fdc35
> Author: Eric Anholt <eric at anholt.net>
> Date:   Thu Jan 23 10:21:09 2014 -0800
>
>     dri2: Trust our own driver name lookup over the server's.
>
>     This allows Mesa to choose to rename driver .sos (or split drivers),
>     without needing a flag day with the corresponding 2D driver.
>
>     v2: Undo the loader-only-for-dri3 change.
>
>     Reviewed-by: Keith Packard <keithp at keithp.com> [v1]
>     Reviewed-by: Kristian H<C3><B8>gsberg <krh at bitplanet.net> [v1]
>
> nouveau_vieux loading no longer works. I investigated a little, and it
> looks like loader_get_pci_id_for_fd doesn't retrieve the pci id for
> nouveau, and even if it did, there is no pci id map like there is for
> other hardware.
>
> I think the simplest solution is to make loader_get_driver_for_fd
> return NULL for nouveau, which in turn would preserve the existing
> logic of using the driver name provided by X.
>
> Thoughts?

I just sent a patch which instead gets the chipset id, and uses that
to return nouveau or nouveau_vieux. I assume that's better, since then
it'll correctly handle the non-X-based cases (which, admittedly,
aren't supported by nouveau_vieux, but they could be.)