[Mesa-dev] [PATCH 1/3] ra: Use bool instead of GLboolean.

Eric Anholt eric at anholt.net
Mon Mar 17 14:40:51 PDT 2014


Kenneth Graunke <kenneth at whitecape.org> writes:

> This isn't the GL API, so there's no reason to use GLboolean.
>
> Using bool is safer: any non-zero value is treated as "true".  When
> converting a value to a GLboolean, all but the low byte is discarded,
> which means that values like 256 will be incorrectly rendered as false.
>
> Done via the following vim commands:
> :%s/GLboolean/bool/g
> :%s/GL_TRUE/true/g
> :%s/GL_FALSE/false/g
> and one line of manual whitespace tidying.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

This series is:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140317/b65bee18/attachment.sig>


More information about the mesa-dev mailing list