[Mesa-dev] [PATCH] nouveau: don't assume libdrm include prefix

Ilia Mirkin imirkin at alum.mit.edu
Thu Mar 20 05:09:41 PDT 2014


On Thu, Mar 20, 2014 at 7:57 AM, Jonathan Gray <jsg at jsg.id.au> wrote:
> On Thu, Mar 20, 2014 at 07:29:32AM -0400, Ilia Mirkin wrote:
>> On Wed, Mar 19, 2014 at 11:43 PM, Jonathan Gray <jsg at jsg.id.au> wrote:
>> > drm headers may be installed in a different directory
>>
>> I'm curious -- how can this happen? Looking at Makefile.am from
>> drm:nouveau/Makefile.am:
>>
>> libdrm_nouveauincludedir = ${includedir}/libdrm
>> libdrm_nouveauinclude_HEADERS = nouveau.h
>
> libdrm is built with bsd makefiles in the OpenBSD xenocara/X11 tree.
> http://www.openbsd.org/cgi-bin/cvsweb/xenocara/lib/libdrm/
>
> The *_drm.h headers are shared between userland and the kernel.
>
> ie what Linux calls the 'uapi' headers can be found in
> /usr/include/dev/pci/drm/
> and the other libdrm headers are currently installed to
> /usr/X11R6/include/
>
> The libdrm*.pc pkg-config files reflect this.

Fair enough. I don't see nouveau in that repo, but I presume you're
working on it, hence this change? (It should be entirely unrelated to
the nouveau_drm.h thing from
https://bugs.freedesktop.org/show_bug.cgi?id=76376 right?)

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

Let me know if you need me to push these changes out.


More information about the mesa-dev mailing list