[Mesa-dev] [PATCH 1/3] gallium/u_blitter: don't adjust cubemap coordinates by a small number

[Roland Scheidegger]

Am 16.03.2014 15:47, schrieb Marek Olšák:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> It may cause issues with mipmap generation.
> I think it was used to make some piglit tests pass on r300g.
> ---
>  src/gallium/auxiliary/util/u_blitter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c
> index 1e7f374..64a3dcf 100644
> --- a/src/gallium/auxiliary/util/u_blitter.c
> +++ b/src/gallium/auxiliary/util/u_blitter.c
> @@ -704,7 +704,7 @@ static void blitter_set_texcoords(struct blitter_context_priv *ctx,
>                                          /* pointer, stride in floats */
>                                          &face_coord[0][0], 2,
>                                          &ctx->vertices[0][1][0], 8,
> -                                        TRUE);
> +                                        FALSE);
>     } else {
>        set_texcoords_in_vertices(coord, &ctx->vertices[0][1][0], 8);
>     }
> 

I'm not entirely sure this is not goint to cause issues - IIRC it may
cause wrong texels to get selected (around cube edges) in some cases. Or
maybe it's not an issue here, this is a hack in any case, so I don't
really object...

Roland