[Mesa-dev] [PATCH 3/3] gallium/u_gen_mipmap: rewrite using pipe->blit

[Marek Olšák]

On Sat, Mar 22, 2014 at 4:54 PM, Roland Scheidegger <sroland at vmware.com> wrote:
> I think this is missing some parameters by not using a sampler view. In
> particular can we please have a separate format here? It may not matter
> for GL (srgb maybe, texture views?), but for this to work with d3d we
> need to be able to specify the format separately in order to work with
> typeless resources, since the resource format was just a guess. And,
> similarly d3d10 wants to specify explicit first/last layer (not for cube
> maps or 3d textures).
> So maybe could just pass a pipe_sampler_view again, drop all the face,
> baseLevel, lastLevel parameters and use the parameters from the view?

u_gen_mipmap wouldn't use the sampler view, so I'll just pass the
format and layer range as function parameters, unless the layer range
is not needed, in which case I only need to add the format.

> (I guess this doesn't work for cube maps with the mesa state tracker
> since for some very odd reason mesa core wants to do this per-face and
> sampler views with just one cube face are illegal but the GL API doesn't
> allow to do this per face so I think this should be trivial to change in

Automatic mipmap generation (GL 1.x) allows generating mipmaps for one
face only, so the face parameters needs to stay for that at least.

> mesa. FWIW this should probably be changed anyway in core mesa if you
> want to be able to do mipmap generation for cube map arrays, which seems
> to be broken actually now completely because _mesa_GenerateMipmap() will
> outright reject cube map arrays.)

I have recently pushed fixes for mipmap generation of cube arrays.

Marek