[Mesa-dev] [PATCH 00/14] Klocwork patches

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Tue Mar 25 05:40:41 PDT 2014


Again fixed my Klocwork set. I reworked Ian's patch because my set depend on
it and Ian's patch seem to have vanished in the void. It needed a small update
because it was breaking "make check".

Matt, about "glsl: add missing null check in tfeedback_decl::init()",
ralloc_strndup failure would be coming from calloc returning null. I changed
the patch to report memory error instead of just retuning null. When calloc
start to return null things anyhow already are in bad shape so I would guess
somehow correct behavior would be to return control for calling program asap.

/Juha-Pekka

Ian Romanick (1):
  mesa: Add _mesa_error_no_memory for logging out-of-memory messages

Juha-Pekka Heikkila (13):
  glx: remove unused __glXClientInfo()
  glx: add extra null check in getFBConfigs
  mesa: Prevent negative indexing on noise2, noise3 and noise4
  mesa: Add missing null check in _mesa_parse_arb_program()
  mesa: remove redundant running of check_symbol_table()
  mesa: add missing null checks in _tnl_register_fastpath()
  mesa: add extra null checks in vbo_rebase_prims()
  mesa: In emit_texenv() type mismatch was forced with typecast
  mesa: Add missing null checks into prog_hash_table.c
  glsl: add missing null check in tfeedback_decl::init()
  mesa: add missing null check in _mesa_NewHashTable()
  i965: check malloc return value in intel_resolve_map_set()
  mesa: add null checks in symbol_table.c

 src/glsl/Makefile.am                          | 13 ++++++---
 src/glsl/link_varyings.cpp                    |  6 +++++
 src/glsl/main.cpp                             |  6 +++++
 src/glsl/tests/common.c                       | 30 +++++++++++++++++++++
 src/glx/glxcmds.c                             | 13 ---------
 src/glx/glxext.c                              |  4 +++
 src/mesa/drivers/dri/i965/intel_resolve_map.c |  7 +++++
 src/mesa/main/errors.c                        |  6 +++++
 src/mesa/main/errors.h                        |  3 +++
 src/mesa/main/ff_fragment_shader.cpp          | 19 +++++++------
 src/mesa/main/hash.c                          | 10 +++++++
 src/mesa/program/prog_hash_table.c            | 10 +++++++
 src/mesa/program/prog_noise.c                 | 36 ++++++++++++-------------
 src/mesa/program/program_parse.y              |  5 ++++
 src/mesa/program/symbol_table.c               | 39 +++++++++++++++++++++++----
 src/mesa/tnl/t_vertex.c                       | 14 ++++++++--
 src/mesa/vbo/vbo_rebase.c                     | 25 ++++++++++++++---
 17 files changed, 193 insertions(+), 53 deletions(-)
 create mode 100644 src/glsl/tests/common.c

-- 
1.8.1.2



More information about the mesa-dev mailing list