[Mesa-dev] [PATCHv3] configure: enable dri3 only for linux

[Ian Romanick]

On 03/25/2014 02:47 PM, Emil Velikov wrote:
> On 21/03/14 18:09, Emil Velikov wrote:
>> Currently only linux can make use of dri3, so it would make sense to
>> enable it explicitly for the platform.
>> Drop a duplicated libudev check while we're at it.
>>
>> v3: Properly handle dri3 and reword commit message.
>>
> Would there be any objections if I slap Cc: mesa-stable... on this patch and
> commit it some time this week ?

It looks reasonable to me.  You might want an additional R-b, but it's

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

anyway.

> -Emil
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76377
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>  configure.ac | 18 ++++++++++++------
>>  1 file changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index c5042f9..af6bfa4 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -528,11 +528,20 @@ AC_ARG_ENABLE([dri],
>>          [enable DRI modules @<:@default=enabled@:>@])],
>>      [enable_dri="$enableval"],
>>      [enable_dri=yes])
>> +
>> +case "$host_os" in
>> +linux*)
>> +    dri3_default=yes
>> +    ;;
>> +*)
>> +    dri3_default=no
>> +    ;;
>> +esac
>>  AC_ARG_ENABLE([dri3],
>>      [AS_HELP_STRING([--enable-dri3],
>> -        [enable DRI3 @<:@default=enabled@:>@])],
>> +        [enable DRI3 @<:@default=auto@:>@])],
>>      [enable_dri3="$enableval"],
>> -    [enable_dri3=yes])
>> +    [enable_dri3="$dri3_default"])
>>  AC_ARG_ENABLE([glx],
>>      [AS_HELP_STRING([--enable-glx],
>>          [enable GLX library @<:@default=enabled@:>@])],
>> @@ -824,9 +833,6 @@ xyesno)
>>          PKG_CHECK_MODULES([DRI2PROTO], [dri2proto >= $DRI2PROTO_REQUIRED])
>>          GL_PC_REQ_PRIV="$GL_PC_REQ_PRIV libdrm >= $LIBDRM_REQUIRED"
>>          if test x"$enable_dri3" = xyes; then
>> -            if test x"$have_libudev" != xyes; then
>> -              AC_MSG_ERROR([DRI3 requires libudev >= $LIBUDEV_REQUIRED])
>> -            fi
>>              PKG_CHECK_MODULES([DRI3PROTO], [dri3proto >= $DRI3PROTO_REQUIRED])
>>              PKG_CHECK_MODULES([PRESENTPROTO], [presentproto >= $PRESENTPROTO_REQUIRED])
>>          fi
>> @@ -979,7 +985,7 @@ if test "x$enable_dri" = xyes; then
>>      gnu*)
>>          DEFINES="$DEFINES -DUSE_EXTERNAL_DXTN_LIB=1"
>>          DEFINES="$DEFINES -DHAVE_ALIAS"
>> -	;;
>> +        ;;
>>      solaris*)
>>          DEFINES="$DEFINES -DUSE_EXTERNAL_DXTN_LIB=1"
>>          ;;
>>
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>