[Mesa-dev] [PATCH 2/2] draw/llvm: improve debugging output a bit

[Jose Fonseca]

Series looks good to me.

Jose

----- Original Message -----
> it's useful to know what the llvmbuildstore arguments are going to
> be before executing it because it can crash and make sure to
> print out the inputs only if we're not generating a gs because
> it fetches inputs differently.
> 
> Signed-off-by: Zack Rusin <zackr at vmware.com>
> ---
>  src/gallium/auxiliary/draw/draw_llvm.c          | 2 +-
>  src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/draw/draw_llvm.c
> b/src/gallium/auxiliary/draw/draw_llvm.c
> index 53d13f3..b9f8bb9 100644
> --- a/src/gallium/auxiliary/draw/draw_llvm.c
> +++ b/src/gallium/auxiliary/draw/draw_llvm.c
> @@ -939,11 +939,11 @@ store_aos_array(struct gallivm_state *gallivm,
>           LLVMValueRef id_ptr = draw_jit_header_id(gallivm, io_ptrs[i]);
>           val = LLVMBuildExtractElement(builder, cliptmp, linear_inds[i],
>           "");
>           val = adjust_mask(gallivm, val);
> -         LLVMBuildStore(builder, val, id_ptr);
>  #if DEBUG_STORE
>           lp_build_printf(gallivm, "io = %p, index %d, clipmask = %x\n",
>                           io_ptrs[i], inds[i], val);
>  #endif
> +         LLVMBuildStore(builder, val, id_ptr);
>        }
>     }
>  
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
> b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
> index d2cb0a0..8791168 100644
> --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
> +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
> @@ -3569,7 +3569,8 @@ static void emit_prologue(struct lp_build_tgsi_context
> * bld_base)
>     if (DEBUG_EXECUTION) {
>        lp_build_printf(gallivm, "\n");
>        emit_dump_file(bld, TGSI_FILE_CONSTANT);
> -      emit_dump_file(bld, TGSI_FILE_INPUT);
> +      if (!bld->gs_iface)
> +         emit_dump_file(bld, TGSI_FILE_INPUT);
>     }
>  }
>  
> --
> 1.8.3.2
>